Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify that room parent nodes must be of type ESCRoom. #70

Merged
merged 2 commits into from
Jan 2, 2024
Merged

docs: Clarify that room parent nodes must be of type ESCRoom. #70

merged 2 commits into from
Jan 2, 2024

Conversation

balloonpopper
Copy link
Collaborator

@StraToN
Copy link
Contributor

StraToN commented Apr 30, 2023

Approved. Thanks a lot!
You have 2 doc8 warnings to fix and you're good to go :)

@StraToN StraToN merged commit 0f8e6c5 into devel Jan 2, 2024
1 check passed
@StraToN StraToN deleted the issue-307 branch January 2, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BHSDuncan BHSDuncan BHSDuncan approved these changes

@StraToN StraToN StraToN approved these changes

@dploeger dploeger Awaiting requested review from dploeger dploeger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation : Rooms must be node2d
3 participants
@balloonpopper @StraToN @BHSDuncan